Find/replace overlay: add test for proper shortcut hints#4193
Merged
HeikoKlare merged 1 commit intoJul 19, 2026
Merged
Conversation
Add regression coverage for the recent fix on the search/replace bars' buttons only showing their shortcut-hint tooltip suffix while the corresponding input field actually has focus, rather than always showing hints for actions that are not currently reachable via that shortcut. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
HeikoKlare
marked this pull request as ready for review
July 19, 2026 08:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#4185 fixed the search/replace bars' buttons showing shortcut-hint tooltips for actions that weren't actually reachable via that shortcut at the time — e.g. both the "search forward" and "replace" buttons showed the same "Enter" hint regardless of which input field had focus, since only one of them is actually bound to Enter depending on context.
That fix had no dedicated regression test. This adds one.
What the test covers
Verifies that a button's shortcut-hint tooltip is only shown while its action is actually reachable via that shortcut — i.e. it appears when the corresponding input field (search or replace) has focus, and disappears again once focus moves elsewhere.
This PR description and the test were generated with the help of Claude Code.