Skip to content

Find/replace overlay: remove obsolete setting of button states #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeikoKlare merged 1 commit into from
Jul 17, 2026
+0 −3
Merged

Find/replace overlay: remove obsolete setting of button states #4189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...nch.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlay.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,6 @@ private void createSearchTools() {
.withImage(FindReplaceOverlayImages.get(FindReplaceOverlayImages.KEY_FIND_NEXT))
.withToolTipText(FindReplaceMessages.FindReplaceOverlay_downSearchButton_toolTip)
.withAction(searchForwardAction).build();
searchForwardButton.setSelection(true); // by default, search down

FindReplaceOverlayAction selectAllAction = new FindReplaceOverlayAction(this::performSelectAll);
selectAllAction.addShortcuts(KeyboardShortcuts.SEARCH_ALL);
Expand Down Expand Up @@ -967,7 +966,6 @@ private void updateFromTargetSelection() {
String selectionText = findReplaceLogic.getTarget().getSelectionText();
if (selectionText.contains("\n")) { //$NON-NLS-1$
findReplaceLogic.deactivate(SearchOptions.GLOBAL);
searchInSelectionButton.setSelection(true);
} else if (!selectionText.isEmpty()) {
if (findReplaceLogic.isAvailableAndActive(SearchOptions.REGEX)) {
selectionText = FindReplaceDocumentAdapter.escapeForRegExPattern(selectionText);
Expand Down Expand Up @@ -1024,7 +1022,6 @@ public void setPositionToTop(boolean shouldPositionOverlayOnTop) {

private void removeSearchScope() {
findReplaceLogic.activate(SearchOptions.GLOBAL);
searchInSelectionButton.setSelection(false);
}

private void setContentAssistsEnablement(boolean enable) {
Expand Down
Loading