Find/replace overlay: Read regex option from model instead button state#4188
Merged
HeikoKlare merged 1 commit intoJul 16, 2026
Conversation
The regex search button state is synchronized from the find/replace logic's option state via a listener, so decorate() reading the button's selection depends on that synchronization having happened. Reading the option directly from the logic removes this hidden ordering dependency and is consistent with how the other consumers (e.g., content assist availability) already query the model. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex search button state is synchronized from the find/replace logic's option state via a listener, so decorate() reading the button's selection depends on that synchronization having happened. Reading the option directly from the logic removes this hidden ordering dependency and is consistent with how the other consumers (e.g., content assist availability) already query the model.