Skip to content

Remove contents of IPageLayout that are deprecated for removal #4066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HeikoKlare wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −42
Open

Remove contents of IPageLayout that are deprecated for removal #4066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions bundles/org.eclipse.ui.workbench/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,25 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<component id="org.eclipse.ui.workbench" version="2">
<resource path="eclipseui/org/eclipse/ui/IPageLayout.java" type="org.eclipse.ui.IPageLayout">
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.IPageLayout"/>
<message_argument value="DEFAULT_FASTVIEW_RATIO"/>
</message_arguments>
</filter>
<filter id="405901410">
<message_arguments>
<message_argument value="org.eclipse.ui.IPageLayout"/>
<message_argument value="getEditorReuseThreshold()"/>
</message_arguments>
</filter>
<filter id="405901410">
<message_arguments>
<message_argument value="org.eclipse.ui.IPageLayout"/>
<message_argument value="setEditorReuseThreshold(int)"/>
</message_arguments>
</filter>
</resource>
<resource path="eclipseui/org/eclipse/ui/ISharedImages.java" type="org.eclipse.ui.ISharedImages">
<filter id="405864542">
<message_arguments>
Expand Down
32 changes: 0 additions & 32 deletions bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/IPageLayout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,15 +176,6 @@ public interface IPageLayout {
*/
float RATIO_MAX = 0.95f;

/**
* The default fast view ratio width.
*
* @since 2.0
* @deprecated discontinued support for fast views
*/
@Deprecated(forRemoval = true, since = "2023-12")
float DEFAULT_FASTVIEW_RATIO = 0.3f;

/**
* The default view ratio width for regular (non-fast) views.
*
Expand Down Expand Up @@ -396,29 +387,6 @@ public interface IPageLayout {
*/
void setEditorAreaVisible(boolean showEditorArea);

/**
* Returns the number of open editors before reusing editors or -1 if the
* preference settings should be used instead.
*
* @return the number of open editors before reusing editors or -1 if the
* preference settings should be used instead.
*
* @deprecated this always returns -1 as of Eclipse 2.1
*/
@Deprecated(forRemoval = true, since = "2023-12")
int getEditorReuseThreshold();

/**
* Sets the number of open editors before reusing editors. If &lt; 0 the user
* preference settings will be used.
*
* @param openEditors the number of open editors
*
* @deprecated this method has no effect, as of Eclipse 2.1
*/
@Deprecated(forRemoval = true, since = "2023-12")
void setEditorReuseThreshold(int openEditors);

/**
* Sets whether this layout is fixed. In a fixed layout, layout parts cannot be
* moved or zoomed, and the initial set of views cannot be closed.
Expand Down
10 changes: 0 additions & 10 deletions ...se.ui.workbench/eclipseui/org/eclipse/ui/internal/e4/compatibility/ModeledPageLayout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,11 +309,6 @@ public String getEditorArea() {
return internalGetEditorArea();
}

@Override
public int getEditorReuseThreshold() {
return -1;
}

@Override
public IPlaceholderFolderLayout getFolderForView(String id) {
MPart view = findPart(perspModel, id);
Expand Down Expand Up @@ -359,11 +354,6 @@ public void setEditorAreaVisible(boolean showEditorArea) {
eaRef.setToBeRendered(showEditorArea);
}

@Override
public void setEditorReuseThreshold(int openEditors) {
// ignored, no-op, same as 3.x implementation
}

@Override
public void setFixed(boolean isFixed) {
// perspModel.setFixed(isFixed);
Expand Down
Loading