Skip to content

Update WorkbenchActionBuilder to use IEclipsePreferences #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepika-u wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −14
Open

Update WorkbenchActionBuilder to use IEclipsePreferences #4061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/WorkbenchActionBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2018 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -27,7 +27,8 @@
import org.eclipse.core.resources.IncrementalProjectBuilder;
import org.eclipse.core.resources.ResourcesPlugin;
import org.eclipse.core.runtime.Platform;
import org.eclipse.core.runtime.Preferences;
import org.eclipse.core.runtime.preferences.IEclipsePreferences;
import org.eclipse.core.runtime.preferences.InstanceScope;
import org.eclipse.jface.action.ActionContributionItem;
import org.eclipse.jface.action.GroupMarker;
import org.eclipse.jface.action.IAction;
Expand Down Expand Up @@ -214,7 +215,7 @@ public class WorkbenchActionBuilder extends ActionBarAdvisor {
// @issue class is workbench internal
private StatusLineContributionItem statusLineItem;

private Preferences.IPropertyChangeListener prefListener;
private IEclipsePreferences.IPreferenceChangeListener prefListener;

// listener for the "close editors automatically"
// preference change
Expand Down Expand Up @@ -305,13 +306,12 @@ public void partBroughtToTop(IWorkbenchPart part) {
getWindow().getPartService().addPartListener(partListener);

prefListener = event -> {
if (event.getProperty().equals(
ResourcesPlugin.PREF_AUTO_BUILDING)) {
if (event.getKey().equals(ResourcesPlugin.PREF_AUTO_BUILDING)) {
updateBuildActions(false);
}
};
ResourcesPlugin.getPlugin().getPluginPreferences()
.addPropertyChangeListener(prefListener);
InstanceScope.INSTANCE.getNode(ResourcesPlugin.PI_RESOURCES)
.addPreferenceChangeListener(prefListener);

// listener for the "close editors automatically"
// preference change
Expand Down Expand Up @@ -835,8 +835,7 @@ public void dispose() {
partListener = null;
}
if (prefListener != null) {
ResourcesPlugin.getPlugin().getPluginPreferences()
.removePropertyChangeListener(prefListener);
InstanceScope.INSTANCE.getNode(ResourcesPlugin.PI_RESOURCES).removePreferenceChangeListener(prefListener);
prefListener = null;
}
if (propPrefListener != null) {
Expand Down Expand Up @@ -1535,11 +1534,13 @@ private IContributionItem getItem(String actionId, String commandId,
.getService(IActionCommandMappingService.class);
acms.map(actionId, commandId);

CommandContributionItemParameter commandParm = new CommandContributionItemParameter(
getWindow(), actionId, commandId, null, sharedImages
.getImageDescriptor(image), sharedImages
.getImageDescriptor(disabledImage), null, label, null,
tooltip, CommandContributionItem.STYLE_PUSH, null, false);
CommandContributionItemParameter commandParm = new CommandContributionItemParameter(getWindow(), actionId,
commandId, CommandContributionItem.STYLE_PUSH);

commandParm.icon = sharedImages.getImageDescriptor(image);
commandParm.disabledIcon = sharedImages.getImageDescriptor(disabledImage);
commandParm.label = label;
commandParm.tooltip = tooltip;
return new CommandContributionItem(commandParm);
}
}
Loading