Migrate ProblemsViewPerformanceTest to JUnit 5#4007
Open
vogella wants to merge 1 commit into
Open
Conversation
Contributor
Migrate the JUnit 4 PerformanceTestCaseJunit4 base class to its JUnit 5 counterpart PerformanceTestCaseJunit5, which manages the PerformanceMeter via @BeforeEach/@AfterEach, and replace CloseTestWindowsRule with CloseTestWindowsExtension.
vogella
force-pushed
the
migrate-problemsview-junit5
branch
from
d492698 to
83d3b3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate this performance test from JUnit 4 to JUnit 5. The test now extends
PerformanceTestCaseJunit5(the JUnit 5 counterpart of the droppedPerformanceTestCaseJunit4), which manages thePerformanceMetervia@BeforeEach/@AfterEach, andCloseTestWindowsRuleis replaced withCloseTestWindowsExtension. Reusing the shared base class keeps the meter handling consistent with all other performance tests instead of reimplementing it locally.