Use java.util.Locale in Workbench NL extensions handling#3991
Open
vogella wants to merge 1 commit into
Open
Conversation
Contributor
Test Results 864 files 864 suites 53m 33s ⏱️ Results for commit 4569ae1. ♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
icu-workbench-ulocale
branch
from
9751d8a to
02780a6
Compare
Replaces com.ibm.icu.util.ULocale usage in Workbench with java.util.Locale and drops the matching Import-Package: com.ibm.icu.util from the bundle manifest. The legacy ICU-style locale extension string from Platform.getNLExtensions() and the NL_EXTENSIONS preference (e.g. "@Calendar=hebrew;numbers=arab") is translated to a BCP 47 Unicode locale extension ("-u-ca-hebrew-nu-arab") and applied via Locale.forLanguageTag, so existing preference values keep working for the common keyword names (calendar, collation, currency, numbers, timezone) as well as for two-letter BCP 47 keys. Removes the last com.ibm.icu reference from org.eclipse.ui.workbench.
vogella
force-pushed
the
icu-workbench-ulocale
branch
from
02780a6 to
4569ae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
com.ibm.icu.util.ULocaleusage inWorkbenchwithjava.util.Localeand drops the matchingImport-Package: com.ibm.icu.utilfrom the bundle manifest. The legacy ICU-style locale extension string fromPlatform.getNLExtensions()and theNL_EXTENSIONSpreference (e.g.@calendar=hebrew;numbers=arab) is translated to a BCP 47 Unicode locale extension (-u-ca-hebrew-nu-arab) and applied viaLocale.forLanguageTag, so existing preference values keep working for the common keyword names (calendar, collation, currency, numbers, timezone) as well as for two-letter BCP 47 keys. Underscores in values are normalized to hyphens so legacy compound values likeislamic_civilare accepted. Unknown keys and ill-formed values are silently dropped, matching the previous best-effortULocalebehavior. Long IANA timezone IDs (America/New_York) are not translated since the JDK does not expose the IANA-to-CLDR short-ID mapping; short BCP 47 timezone IDs (@tz=usnyc) still work. This removes the lastcom.ibm.icureference fromorg.eclipse.ui.workbench.Planned for 4.41