[Cocoa] Add generation instructions for PDF export functions#3446
Open
HeikoKlare wants to merge 1 commit into
Open
[Cocoa] Add generation instructions for PDF export functions#3446HeikoKlare wants to merge 1 commit into
HeikoKlare wants to merge 1 commit into
Conversation
Contributor
The CGPDFContext* functions are all present in the CoreGraphicsFull.bridgesupport files but were never registered in the corresponding .extras files, so MacGenerator silently dropped them on the next regeneration. This adds the missing swt_gen="true" entries and reruns the MacGenerator to adopt its ordering of generated entries in the OS class. Follow-up to eclipse-platform#2882 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
HeikoKlare
force-pushed
the
save-generated-appkitbridge-fix
branch
from
5c2a345 to
e2f8e8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CGPDFContext*functions are all present in the CoreGraphicsFull.bridgesupport files but were never registered in the corresponding .extras files, so MacGenerator silently dropped them on the next regeneration. This adds the missingswt_gen="true"entries and reruns the MacGenerator to adopt its ordering of generated entries in the OS class.Follow-up to:
@laeubi fyi in case this unexpectedly breaks something for PDFDocument on MacOS