[Cocoa] Remove deprecated scroller part constants#3432
Merged
HeikoKlare merged 1 commit intoJul 16, 2026
Merged
Conversation
Contributor
NSScrollerDecrementLine and NSScrollerIncrementLine are deprecated since macOS 10.14 without replacement, as scrollers do not have arrow buttons anymore since macOS 10.7. Remove the constants together with the dead switch cases in ScrollBar and Slider that handled hits on the no longer existing scroller arrows. Contributes to eclipse-platform#3214 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
HeikoKlare
force-pushed
the
remove-deprecated-scroller-part-constants
branch
from
6bc59a3 to
92ae80e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constants
NSScrollerDecrementLineandNSScrollerIncrementLineare deprecated since macOS 10.14 without replacement, as scrollers do not have arrow buttons anymore since macOS 10.7. Consequently,hitPart()/testPart()can never return these values on any supported macOS version.This change removes the constants from
OS.javaand the bridgesupport extras, together with the dead switch cases inScrollBar#sendSelectionandSlider#sendSelectionthat handled hits on the no longer existing scroller arrows (which producedSWT.ARROW_UP/SWT.ARROW_DOWNevent details).Contributes to #3214
🤖 Generated with Claude Code