Skip to content

CTabFolder overlap calculations change #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
Jun 30, 2026
+10 −1
Merged

CTabFolder overlap calculations change #3408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .../org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2678,7 +2678,7 @@ int getChevronCount() {
private void updateChevronImage(boolean styleChange) {
if (styleChange && chevronImage == null) return;
int newCount = getChevronCount();
if (!styleChange && chevronCount == newCount) return;
if (!styleChange && chevronImage != null && chevronCount == newCount) return;
if (chevronImage != null) chevronImage.dispose();
chevronImage = createButtonImage(getDisplay(), CTabFolderRenderer.PART_CHEVRON_BUTTON);
chevronItem.setImage(chevronImage);
Expand Down Expand Up @@ -3999,6 +3999,15 @@ boolean updateItems (int showIndex) {
changed |= setItemSize(gc);
}
}
if (showChevron) {
// Give the chevron its image (and thus its real preferred size) before
// setItemLocation decides how many tabs are showing. Both setItemLocation
// and computeControlBounds reserve space for the chevron via
// getRightItemEdge(); an image-less chevron measures much smaller than the
// final one, which would let an extra tab remain visible and make the
// chevron overlap the trailing controls (e.g. the min/max toolbar).
updateChevronImage(false);
}
changed |= setItemLocation(gc);
setButtonBounds();
changed |= chevronChanged;
Expand Down
Loading