[Win32] Remove unnecessary color disposal in GC#3316
Merged
HeikoKlare merged 1 commit intoMay 30, 2026
Conversation
Contributor
fedejeanne
reviewed
May 29, 2026
Member
fedejeanne
left a comment
fedejeanne
left a comment
There was a problem hiding this comment.
LGTM but just for my understanding: the reason we shouldn't dispose the Colors is because they are either system colors (which should live through the whole applications LC) or they are created outside of our control (in which case the creator should dispose them). Or did I get it wrong?
Member
Colors don't need to be disposed at all anymore (independently of context), they are not system resources anymore after SWT changes. |
Member
|
Indeed, thank you for the pointer! |
fedejeanne
approved these changes
May 29, 2026
GC operations unnecessarily register stored colors for disposal, though colors do not need to be disposed anymore. This change removes the obsolete disposal tracking. Contributes to eclipse-platform#3296
HeikoKlare
force-pushed
the
win32-gc-remove-color-dispose
branch
from
168241f to
22ddea7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GC operations unnecessarily register stored colors for disposal, though colors do not need to be disposed anymore. This change removes the obsolete disposal tracking.
Contributes to #3296