change: replace unnecessary streaming responses - #2029
Draft
netomi wants to merge 1 commit into
Draft
Conversation
cstamas
reviewed
Aug 5, 2026
| testlogger { | ||
| // By default only frames of the test class itself are shown, which hides where a failure | ||
| // actually originated - useless for diagnosing failures that only reproduce on CI. | ||
| showFullStackTraces true |
Member
There was a problem hiding this comment.
Suggested change
| showFullStackTraces true | |
| showFullStackTraces = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixes in #2028 solve the failures with streaming response bodies in a test environment, however, Claude pointed out that the same problem could still be present in a production setup.
This PR replaces the existing endpoints returning
StreamingResponseBodywith regular ones as all the content is eagerly loaded anyway and returning a streaming response seems unnecessary.Maybe this was due to a refactoring and early on the streaming response made sense.
Needs more investigation, open as draft for now.