Add optional externalRef to distribution set assignment requests - #3305
Open
herdt-michael wants to merge 1 commit into
Open
Add optional externalRef to distribution set assignment requests#3305herdt-michael wants to merge 1 commit into
herdt-michael wants to merge 1 commit into
Conversation
Signed-off-by: Michael Herdt <michael.herdt@bosch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MgmtDistributionSetAssignment and MgmtTargetAssignmentRequestBody were extended with an optional externalRef field. The value is propagated through TargetWithActionType/DeploymentRequest down to JpaAction creation in AbstractDsAssignmentStrategy, where it is set if provided. Instead of adding new tests, the existing weightValidation tests in MgmtDistributionSetResourceTest and MgmtTargetResourceTest were extended to verify that the field is persisted on the resulting action. Two direct DeploymentRequest constructor calls in JPA tests were adjusted to the new signature.