Make imported applet packages optional#283
Draft
OndroMih wants to merge 1 commit intoeclipse-ee4j:masterfrom
Draft
Make imported applet packages optional#283OndroMih wants to merge 1 commit intoeclipse-ee4j:masterfrom
OndroMih wants to merge 1 commit intoeclipse-ee4j:masterfrom
Conversation
Applets were removed from Java 26, they cannot be imported if running on Java 26 or newer. Making them optional will allow using the functionality on Java 26 that doesn't depend on applets.
Contributor
Contributor
|
Did also tests pass? That would be an awesome signal that it could be possible to remove it completely. |
dmatej
approved these changes
Apr 11, 2026
Author
|
I didn’t run tests. I can try to modify a Jenkins job to build orb and build GlassFish against a snapshot version and then run tests. I’ll try it. |
Author
|
This is not enough to make GlassFish work on Java 26. GlassFish uses several Orb classes that refer to applets and fail to load. At least the tests fail because easymock wants to load all methods when it creates the mocks, see: https://ci.eclipse.org/glassfish/job/daily_builds/job/GlassFish-Java26/org.glassfish.main.common$glassfish-naming/18/testReport/junit/com.sun.enterprise.naming.impl/GlassfishNamingManagerImplTest/initializeRemoteNamingSupport/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applets were removed from Java 26, they cannot be imported if running on Java 26 or newer. Making them optional will allow using the functionality on Java 26 that doesn't depend on applets.