feat!: adopt the SQL model and dialect framework from jdbc.db#34
Merged
Merged
Conversation
stbischof
force-pushed
the
wip/sqlquery-querymap
branch
from
July 14, 2026 18:01
16f1c74 to
e260478
Compare
Bring the SQL vocabulary (org.eclipse.daanse.sql.model), the dialect framework (org.eclipse.daanse.sql.dialect.*) and the JDBC modules (org.eclipse.daanse.sql.jdbc.*: api, record, metadata, impl, importer/csv) into this repo from org.eclipse.daanse.jdbc.db. This repo now owns the whole SQL + JDBC stack as one acyclic reactor and depends on no jdbc.db artifact. That removes the cross-repo cycle which deadlocked CI: jdbc.db needed sql.model at compile scope while the dialect tests here needed jdbc.db at test scope, so neither repo could build first and each resolved a stale snapshot of the other. Also declare the jdbc record dependency in dialect/db/derby, which previously compiled only through a transitive pull via impl. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
stbischof
force-pushed
the
wip/sqlquery-querymap
branch
from
July 14, 2026 18:02
e260478 to
302c173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
model/ (org.eclipse.daanse.sql.model) and dialect/ (org.eclipse.daanse.sql.dialect.* — api, common, test-support and the 12 active engine dialects) are plain FILE COPIES from org.eclipse.daanse.jdbc.db at 034d4ee5270fd812a46b43d3901882081823decf, which deleted them again in 24f854dc0f9e1961aa8dc9874538d83bb95e13e0; their development history lives in that repository. The 27 inactive attic dialects were not copied.
statement, guard and deparser repoint their imports/deps from org.eclipse.daanse.jdbc.db.dialect.* to org.eclipse.daanse.sql.dialect.* and from the jdbc.db.api vocabulary packages to
org.eclipse.daanse.sql.model.*; the guard test bndrun additionally runs the sql.model bundle.
Layering inside this repo (bottom-up): model -> dialect -> statement ->
guard/deparser. Remaining cross-repo deps (jdbc.db.api/record/impl/ metadata) are test-scope only, pinned literal 0.0.1-SNAPSHOT.
eclipse-daanse/org.eclipse.daanse.jdbc.db#65