add types.pyi for improved type checker support#330
Open
ZZZank wants to merge 2 commits intoeclipse-cyclonedds:masterfrom
Open
add types.pyi for improved type checker support#330ZZZank wants to merge 2 commits intoeclipse-cyclonedds:masterfrom
types.pyi for improved type checker support#330ZZZank wants to merge 2 commits intoeclipse-cyclonedds:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some type checkers provided the ability to infer result of
SomeClass[T]on non-generic class, based on the return type of__class_getitem__(...). So this PR addedtypes.pyi, with proper__class_getitem__(...)definition for type classes intypes.py, allowing type checkers to provide more accurate result.Tests below are performed using Pyrefly in VSCode.
Before:
After:
