Skip to content

fix: remove Vale control directives that trigger RedHat.Spacing errors#3169

Merged
gtrivedi88 merged 1 commit into
eclipse-che:7.120.xfrom
gtrivedi88:fix-vale-directives-7120x
Jul 23, 2026
Merged

fix: remove Vale control directives that trigger RedHat.Spacing errors#3169
gtrivedi88 merged 1 commit into
eclipse-che:7.120.xfrom
gtrivedi88:fix-vale-directives-7120x

Conversation

@gtrivedi88

Copy link
Copy Markdown
Contributor

Summary

Backport of #3167 to 7.120.x.

Removes pass:[<!-- vale RedHat.Spelling = NO/YES -->] lines that cause the publication builder to fail.

Why the publication builder fails on 7.120.x

  1. tools/validate_language_changes.sh diffs against origin/main
  2. After fix: restore Vale control directives to HTML passthrough format #3167 merged to main (removing these directives), the file on 7.120.x now differs from main
  3. Vale lints the file, sees "RedHat.Spelling" text inside the directives, and RedHat.Spacing flags it as an error
  4. 2 errors → exit code 1 → build fails

Why this fix works

  • Removing the directives eliminates the 2 errors
  • The {prod-checluster} text these directives were suppressing only produces a spelling warning, not an error
  • Vale exits 0 when only warnings are present → build passes

Test plan

  • Publication builder CI passes on 7.120.x (0 errors)

Made with Cursor

Backport of eclipse-che#3167 to 7.120.x. The RedHat.Spacing rule flags "RedHat.Spelling"
text inside Vale control directives as improperly joined words. Remove the
directives since {prod-checluster} only produces a spelling warning, not an
error that would fail the build.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gtrivedi88
gtrivedi88 requested review from a team, deerskindoll and mkuznyetsov as code owners July 22, 2026 15:57
@gtrivedi88
gtrivedi88 requested review from tolusha and removed request for a team July 22, 2026 15:57
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

🎊 Navigate the preview: https://6a60ea1808ec763022de9289--eclipse-che-docs-pr.netlify.app 🎊

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Click here to review and test in web IDE: Contribute

@gtrivedi88
gtrivedi88 merged commit 47c7304 into eclipse-che:7.120.x Jul 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants