Add not_found protocol overrides at bip37. - #9
Open
echennells wants to merge 1 commit into
Open
Conversation
echennells
force-pushed
the
notfound-70001
branch
from
September 8, 2026 15:42
b3051d5 to
0f6b385
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework of libbitcoin#1106 per the 2026-08-31 review: not_found is a protocol level, not a condition on
_106.protocol_block_out_70001andprotocol_transaction_out_70001derive from the_106classes and overridehandle_unservable. The_106classes retain the stop, asnot_foundis undefined below bip37;protocol_block_out_70012now derives from_70001. The session attaches the derived protocol when bip37 is negotiated. The reply is gated bypeer.enable_not_found, routed through config and parse.A hash resolving to no header is answered before the checkpoint height query, which faults the store on a terminal link.
Six cases in
test/functional/p2p.cppcover unknown, pruned and unassociated blocks, an unknown transaction, a peer below bip37, and the option disabled; fixtures live inp2p_setup_fixture.Depends on echennells/libbitcoin-network
peer-enable-not-foundand echennells/libbitcoin-serverpeer-enable-not-found-parser.Fork-internal. Verified 2026-09-08 against upstream heads in a container: functional_p2p_tests 9/9, 158 assertions; network settings 59/59; server parser compiles. Fork CI 43/43 green. Upstream body drafted at
~/ech-sep7/pr1106/upstream-body.md.