fix: verify required vendor SDK options#42
Merged
Conversation
ebarti
force-pushed
the
agent/stack-02-required-kwargs-security
branch
from
36b6a62 to
2750db3
Compare
ebarti
added a commit
that referenced
this pull request
Jul 10, 2026
## What - add JSON Schema as a lightweight core dependency - reject malformed or non-JSON schemas with OutputSchemaError - enforce strict Pydantic validation while preserving duck-model compatibility - distinguish valid JSON null from absent structured output - make AgentKit clear both payload and presence state on typed failures - validate the vendor-independent fake runtime ## Why The public contract claimed strict typed output, but malformed schemas were accepted, Pydantic coerced values, and null was indistinguishable from parse failure. ## Root cause Schema generation and typed parsing existed, but there was no local meta-schema layer or explicit parsed-output presence bit. ## Checks - 284 passed, 12 skipped - ruff check src tests - mypy - uv lock --check - wheel and sdist build ## Stack - Base: #42 - Next: provider-wide output-schema enforcement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
A callable that accepts **kwargs can silently discard an option while appearing compatible. That is unsafe for permission posture and budget caps.
Root cause
The shared option filter treated variadic and uninspectable signatures as proof that every required option would be honored.
Checks
Stack