Implement status bar updates during fitting#302
Open
rozyczko wants to merge 3 commits into1.2.0_fixes2from
Open
Implement status bar updates during fitting#302rozyczko wants to merge 3 commits into1.2.0_fixes2from
rozyczko wants to merge 3 commits into1.2.0_fixes2from
Conversation
Member
Author
|
This needs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the fitting progress reporting and user interface feedback in ERA. The changes add new properties and signals to track and display in-flight fitting progress, such as current iteration, interim chi-squared values, and progress messages.
Fitting Progress Tracking and Exposure:
Added new properties to the Python backend logic (
fitting.py) and QML interfaces to track and expose fitting progress, including current iteration, interim chi-squared, reduced chi-squared, progress messages, and preview parameter values. These are now available in both the backend (analysis.py) and frontend (BackendWrapper.qml).Implemented a mechanism for the fitting worker thread to emit detailed progress updates via a new
progressDetailsignal, which is handled in the backend to update the fitting state and propagate changes to the UI.User Interface Enhancements:
Updated the status bar to display live fitting progress, including the current iteration and reduced chi-squared, with fallback animation when interim updates are not available.
Ensured that fit progress and results dialogs are properly managed and dismissed on both acceptance and rejection, improving UI consistency.
Refactored the loading and placement of the
FitStatusDialogcomponent to avoid redundant instantiation and ensure it's available at the correct UI level.Fitting Operation Robustness and State Management:
Improved state management by clearing progress information on fit completion, cancellation, or failure, ensuring the UI always reflects the current fitting state.
Enhanced error handling for user-initiated fit cancellation, providing clear messaging and preventing unnecessary error dialogs.