Open
Conversation
seventil
added
[priority] low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue with previous implementation was that with
interactive: falsethe background gets the 4px width, and contentItem width is then recalculated to 0 but widening it and making it visible on hover.The fix makes the scrollBar to behave like scrollIndicator if
interactive: falseThe fix ensures the contentItem is visible when non-interactive and makes the width logic simpler: if the scrollBar is interactive, we have width-changing logic, if not - the width doesn't change on hover. The wider padding for non-interactive item looks worse, as it just creates a 1px detatchment from the border, so I removed that as well.