Bring in changes from upstream v0.11.2#127
Draft
elichad wants to merge 354 commits into
Draft
Conversation
…ntifier properties of the Root Data Entity
…e 1.2 checkers - Reorder imports consistently (stdlib → third-party → local) - Extract helper methods (_resolve_cite_as_url, _not_downloadable_message, _needs_sddatepublished_check, _check_entity_local_path, _check_distribution) - Replace try/except/pass with contextlib.suppress - Flatten nested conditionals with combined guards - Use e!s over str(e) in f-strings - Normalize quote style and multi-line formatting
…-Crate 1.2 test suite
…t-ci-precommit ♻️ refactor: address code quality issues
feat(ro-crate-1.2): introduce validation profile for RO-Crate 1.2
- certifi (2026.5.20 -> 2026.6.17) - mistune (3.2.1 -> 3.3.2) - msgpack (1.2.0 -> 1.2.1) - coverage (7.14.1 -> 7.14.3) - prettytable (3.17.0 -> 3.18.0) - pytest (9.1.0 -> 9.1.1) - virtualenv (21.5.0 -> 21.5.1) - ruff (0.15.17 -> 0.15.19)
Add an abort mechanism to the validation framework so a check can stop the whole run when the metadata is unreadable (e.g. the file descriptor is not valid JSON), instead of letting later checks emit false positives.
…lidation Make the "File Descriptor JSON format" check (RO-Crate 1.1 and 1.2) catch JSONDecodeError explicitly: report a precise issue with the parse error message and line/column, then call context.abort_validation() so no metadata is read and downstream checks don't emit false positives.
…on-abort feat(validation): ✨ abort validation when the file descriptor is not valid JSON
Set `path_type=Path` on the `--output-file` click option so the value is parsed as a `pathlib.Path` instead of a plain string, ensuring consistent path handling.
fix(cli): 🐛 write validation report to --output-file (crs4#182)
elichad
force-pushed
the
upstream-develop
branch
from
a1b7b67 to
1c6b29e
Compare
elichad
commented
Jul 10, 2026
| json.dump(rocrate, f) | ||
| if rocrate_entity_mod_sparql is not None: | ||
| rocrate_graph = load_graph_and_preserve_relative_ids(rocrate) | ||
| if _uses_https_schema(rocrate_graph): |
Author
There was a problem hiding this comment.
code smell - don't think we expect to have https schema in crates at all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has just the upstream changes; expecting to see test failures & merge conflicts
edit: now merged with our develop & conflicts resolved