[#24620] Added regression tests#542
Open
Danipiza wants to merge 3 commits into
Open
Conversation
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
zesk1999
requested changes
Jun 16, 2026
zesk1999
left a comment
zesk1999
left a comment
There was a problem hiding this comment.
Great job! Just one nit present from before.
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added regression tests for DDS-Pipe Dispose fix in DDS-Router repeater
Compilation & Testing
colcon build --packages-select ddspipe_participants ddsrouter_core --cmake-args -DBUILD_TESTS=ON --allow-overriding ddspipe_participants ddsrouter_core colcon test --packages-select ddsrouter_core --ctest-args -R DDSTestRepeaterDisposeKey --event-handlers console_direct+Artifacts
ddspipe_build: https://github.com/eProsima/eProsima-CI/actions/runs/27612271887 🟢
ddspipe_build: https://github.com/eProsima/eProsima-CI/actions/runs/27612284847 🟢
DDS-Router with the DDS-Pipe fix: Action 🟢
DDS-Router with the DDS-Pipe fix (with revision): Action