Skip to content

fix(ci): skip eplus-bot self-approval#59

Merged
hoangsvit merged 1 commit into
mainfrom
fix/skip-bot-self-approval
Jul 14, 2026
Merged

fix(ci): skip eplus-bot self-approval#59
hoangsvit merged 1 commit into
mainfrom
fix/skip-bot-self-approval

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Summary

Prevent pr-auto-approve from failing when the pull request was created by eplus-bot itself.

Root cause

GitHub does not allow an account to approve its own pull request. Changelog pull requests are created by eplus-bot, while the generic auto-approval workflow also authenticates as eplus-bot, causing:

Review Can not approve your own pull request

Changes

  • Resolve and record the pull request author before waiting for checks.
  • Set should_approve=false when the PR author matches the authenticated approver.
  • Skip the wait, approval, and approval-comment steps for self-authored PRs.
  • Keep the changelog release flow intact: its PR is approved separately by github-actions[bot] in release.yml.

Expected result

  • Human-authored PRs continue to receive eplus-bot approval after checks pass.
  • PRs created by eplus-bot finish this workflow successfully without attempting self-approval.
  • Changelog PRs remain eligible for automatic approval and merge through the release workflow.

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@eplus-bot

Copy link
Copy Markdown
Contributor

Thank you for creating this pull request and helping make the project better.

We will review / merge it when we are online.

@eplus-bot eplus-bot added needs-review Pull request is ready for maintainer review build-ci Build, CI, release, or project configuration labels Jul 14, 2026
@eplus-bot
eplus-bot self-requested a review July 14, 2026 23:54
@deepsource-io

deepsource-io Bot commented Jul 14, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 1ffe1de...3141418 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Jul 14, 2026 11:54p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@eplus-bot eplus-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @eplus-bot after all pull request checks passed.

CI run: https://github.com/ePlus-DEV/gmail-alias-toolkit/actions/runs/29377509537

@eplus-bot

Copy link
Copy Markdown
Contributor

CI passed

Approved by @eplus-bot after all pull request checks passed.

Approval refresh: #1
CI updated: 2026-07-14T23:55:12Z
CI attempt: #1
Approval workflow: #184.1

CI run: https://github.com/ePlus-DEV/gmail-alias-toolkit/actions/runs/29377509537

@hoangsvit
hoangsvit merged commit 7f2569d into main Jul 14, 2026
7 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for helping make Gmail Alias Toolkit better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-ci Build, CI, release, or project configuration needs-review Pull request is ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants