feat(api): add sort order to GET /v2/sandboxes#3287
Open
drankou wants to merge 4 commits into
Open
Conversation
❌ 11 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for sorting sandboxes by start time in both ascending and descending order (defaulting to descending) in the list sandboxes endpoint. It updates the OpenAPI specification, database queries, pagination logic, and in-memory sorting/filtering to support the new order query parameter. Additionally, it truncates the pagination timestamp to microsecond precision to ensure consistency between running sandboxes and database snapshots. Feedback suggests validating the order query parameter against its enum values to return a bad request error for invalid inputs instead of silently defaulting to descending.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2fd3a4014
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Add an order=asc|desc query param to GET /v2/sandboxes so clients can request ascending or descending order by sandbox start time (defaults to desc, the previous hardcoded behavior). - Ascending is implemented as the exact reverse of the existing keyset order (started_at ASC, sandbox_id DESC), so it maps onto a backward scan of the existing idx_snapshots_team_time_id index - no new index/migration. - Add a direction-aware first-page cursor, ascending variants of the in-memory sort and cursor filter, and a GetSnapshotsWithCursorAsc keyset query. - Thread the direction through the v2 handler; the legacy v1 list is untouched. - Tests: ascending default cursor, sort + cursor-filter tie-breaks, and a DB-backed test asserting oldest-first ordering and gap-free pagination.
The bare OR cursor predicate never became an index condition, so every deep ascending page rescanned the team's index range from the oldest row (~30s at 43M rows deep on the largest team). Adding a redundant AND-ed >= bound lets the planner seek directly to the cursor (<1ms, verified with EXPLAIN ANALYZE). Also add the active_envs join that the descending query gained on main after the original PR, so both directions exclude soft-deleted envs.
drankou
force-pushed
the
drankou/v2-sandboxes-sort-order
branch
from
e000c7c to
eeb5ff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an
order=asc|descquery param toGET /v2/sandboxesso clients can request ascending or descending order by sandbox start time. Defaults todesc, so existing callers are unaffected.Revives #3107 (rebased on current main). Motivated by the dashboard sandbox list, which otherwise sorts only the client-side loaded pages.
Changes
idx_snapshots_team_time_idindex via a newGetSnapshotsWithCursorAsckeyset query.GetSandboxesis untouched.Test
go test ./internal/utils/... ./internal/handlers/...and DB-backedpackages/db/pkg/tests/snapshots/...pass;golangci-lintclean.