Skip to content

feat(preferred): add kafkajs replacement#827

Open
mcollina wants to merge 1 commit into
e18e:mainfrom
mcollina:feat/add-kafkajs-replacement
Open

feat(preferred): add kafkajs replacement#827
mcollina wants to merge 1 commit into
e18e:mainfrom
mcollina:feat/add-kafkajs-replacement

Conversation

@mcollina

Copy link
Copy Markdown

🔗 Linked issue

Closes #825

📚 Description

Add documented KafkaJS replacements.

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @mcollina LGTM ✌🏻

Comment thread docs/modules/kafkajs.md

<!-- prettier-ignore -->
```js
const { Kafka } = require('kafkajs') // [!code --]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we really should be using ESM in the examples i think

Comment thread docs/modules/kafkajs.md

await producer.connect() // [!code --]
await producer.send({
topic: 'events', // [!code --]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is removed in migration but doesn't seem to be introduced anywhere else. whats the equivalent of this in the replacement libraries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Replacement]: kafkajs abandoned

3 participants