Skip to content

Add all tools as a first step#1

Open
rochauha wants to merge 28 commits intomainfrom
ronak/transfer
Open

Add all tools as a first step#1
rochauha wants to merge 28 commits intomainfrom
ronak/transfer

Conversation

@rochauha
Copy link
Copy Markdown
Member

It is possible that some changes to the tools might require changes to Dyninst as well.

@rochauha rochauha self-assigned this Apr 21, 2026
@rochauha
Copy link
Copy Markdown
Member Author

rochauha commented Apr 21, 2026

Here are two things still remaining:

  • ✅ 1. Create PR in ELFIO to avoid warning - ELFIO PR #168
  • 2. Add functionality to support temporary directory for intermediate files

@rochauha
Copy link
Copy Markdown
Member Author

Turns out temp directory will require modifying Dyninst as well. This PR is ready for review.

Copy link
Copy Markdown

@hainest hainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are able to bump to CMake 3.21, you can use the built-in HIP support (https://rocm.docs.amd.com/en/latest/conceptual/cmake-packages.html).

Comment thread extract-fatbin.cpp Outdated
Comment thread extract-fatbin.cpp Outdated
Comment thread extract-gpubin.cpp Outdated
Comment thread extract-gpubin.cpp Outdated
Comment thread extract-gpubin.cpp Outdated
Comment thread extract-gpubin.cpp Outdated
Comment thread extract-gpubin.cpp Outdated
@rochauha
Copy link
Copy Markdown
Member Author

Addressed comments by @hainest. Please let me know if you have more.

@rochauha
Copy link
Copy Markdown
Member Author

If you are able to bump to CMake 3.21, you can use the built-in HIP support (https://rocm.docs.amd.com/en/latest/conceptual/cmake-packages.html).

I can't bump CMake version on the machine. But this can be done in the future.

@rochauha
Copy link
Copy Markdown
Member Author

@kupsch and @bbiiggppiigg, please let me know if you have any comments.

Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
Comment thread README.md

## Building
```
cmake /path/to/amd_gpu_tools -DROCM_PATH=/path/to/rocm/install
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include initializing the submodules, and making the targets:

Suggested change
cmake /path/to/amd_gpu_tools -DROCM_PATH=/path/to/rocm/install
AGP_SRC=/path/to/amd_gpu_tools
AGP_BUILD=/path/to/amd_gpu_tools_builddir
ROCM_INSTALL=/path/to/rocm/install
cd $AMD_GPU_TOOLS
git submodule update --init --recursive
cmake -DROCM_PATH=$ROCM_INSTALL -B $AGP_BUILD -S $AGP_SRC
cd $AGP_BUILD
make

Comment thread update-fatbin.cpp Outdated
Comment thread update-fatbin.cpp Outdated
Comment thread update-fatbin.cpp Outdated
Comment thread update-fatbin.cpp Outdated
Comment thread update-note.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants