Conversation
|
Here are two things still remaining:
|
|
Turns out temp directory will require modifying Dyninst as well. This PR is ready for review. |
hainest
left a comment
There was a problem hiding this comment.
If you are able to bump to CMake 3.21, you can use the built-in HIP support (https://rocm.docs.amd.com/en/latest/conceptual/cmake-packages.html).
|
Addressed comments by @hainest. Please let me know if you have more. |
I can't bump CMake version on the machine. But this can be done in the future. |
|
@kupsch and @bbiiggppiigg, please let me know if you have any comments. |
|
|
||
| ## Building | ||
| ``` | ||
| cmake /path/to/amd_gpu_tools -DROCM_PATH=/path/to/rocm/install |
There was a problem hiding this comment.
Include initializing the submodules, and making the targets:
| cmake /path/to/amd_gpu_tools -DROCM_PATH=/path/to/rocm/install | |
| AGP_SRC=/path/to/amd_gpu_tools | |
| AGP_BUILD=/path/to/amd_gpu_tools_builddir | |
| ROCM_INSTALL=/path/to/rocm/install | |
| cd $AMD_GPU_TOOLS | |
| git submodule update --init --recursive | |
| cmake -DROCM_PATH=$ROCM_INSTALL -B $AGP_BUILD -S $AGP_SRC | |
| cd $AGP_BUILD | |
| make |
It is possible that some changes to the tools might require changes to Dyninst as well.