fix(security): force TLS on the RDS connection (parameter group + sslmode=require)#72
Open
Androz2091 wants to merge 1 commit intomainfrom
Open
fix(security): force TLS on the RDS connection (parameter group + sslmode=require)#72Androz2091 wants to merge 1 commit intomainfrom
Androz2091 wants to merge 1 commit intomainfrom
Conversation
Two-sided enforcement so there's no plaintext gap: - New aws_db_parameter_group with rds.force_ssl=1. The server refuses any non-TLS connection. Static parameter; takes effect on next Postgres reboot (RDS does it during the maintenance window or you can force it via the console). - Append ?sslmode=require to the POSTGRES_URL secret. SQLAlchemy / psycopg2 will refuse to negotiate plaintext on its end. Without sslmode=require, psycopg2 will accept plaintext if the server allows it; without rds.force_ssl, the server allows plaintext if the client asks for it. Both flips together close the loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two-sided fix from the security review:
aws_db_parameter_groupwithrds.force_ssl=1(server refuses plaintext).?sslmode=requireappended to the POSTGRES_URL secret (client refuses plaintext).Both together close the gap. Static parameter, so the change takes effect on next Postgres reboot (RDS handles it during the next maintenance window, or you can force a reboot from the console after applying).