fix(security): stop logging the package link (it contains the UPN key)#71
Open
Androz2091 wants to merge 1 commit intomainfrom
Open
fix(security): stop logging the package link (it contains the UPN key)#71Androz2091 wants to merge 1 commit intomainfrom
Androz2091 wants to merge 1 commit intomainfrom
Conversation
The package link ends with ?upn=<UPN_KEY>, where UPN is the AES key the
worker uses to encrypt that user's data. Logging the link puts the
decryption key in CloudWatch for the duration of the log group's
retention window (30 days), which contradicts the README's stated
security model ('encryption key must always remain on the client side,
must never be stored on the server side').
Drop the link from the print; package_id alone is enough to correlate
log lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link printed at the start of
process_packageishttps://click.discord.com/ls/click?upn=<UPN_KEY>. The UPN is the AES key for the encrypted blob, so it was sitting in CloudWatch in plaintext for 30 days, contradicting the README's claim that the key never reaches the server.Just drop
linkfrom the print. package_id alone is enough to correlate log lines.