LIST-EXTENDED, part 1: response data item types - #716
Open
soywod wants to merge 1 commit into
Open
Conversation
soywod
force-pushed
the
types/list-extended-response
branch
from
July 29, 2026 14:24
59aa512 to
2c408ca
Compare
soywod
force-pushed
the
types/list-extended-response
branch
from
July 29, 2026 14:35
2c408ca to
0ca15ab
Compare
LIST-EXTENDED: part 1: response data item typesLIST-EXTENDED, part 1: response data item types
soywod
force-pushed
the
types/list-extended-response
branch
from
July 29, 2026 15:12
0ca15ab to
b4a6b63
Compare
Collaborator
Coverage Report for CI Build 30464725878Coverage decreased (-0.1%) to 91.249%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
Author
|
Coverage should improve by itself with codec-related changes (future PRs). |
Owner
|
Looks good to me! I would still need more time to read the RFC and validate all the details to vouch for it. But this is unfortunately not possible for me time-wise currently. What do you think about this approach? We feature-gate the extension (which is our "still experimental marker") and then we can be generally more relaxed about the code, interface, structure, .... I would then basically do my best to guide you but otherwise just trust that you got the details right. If you notice (in production) that something still needs to change, we can just do the change w/o worrying about semver too much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LIST-EXTENDEDis a big piece, so I decided to split into independent PRs. Here the part 1 that contains the response data item types.Refs: #350