[Config-driven linear onboarding dialogs] Port existing screens (skip flow + dock/widget steps) - #9404
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d6b0a7c. Configure here.
LukasPaczos
force-pushed
the
refactor/lpaczos/config-driven-linear-onboarding-dialogs/quick-setup-dock-widget
branch
from
August 5, 2026 15:02
ce4cc4a to
0fbbd40
Compare
(cherry picked from commit a0fefd9)
(cherry picked from commit 136e989)
(cherry picked from commit a791450)
… two traps (cherry picked from commit 5ac3c80)
A declined system dialog arrives before onResume, so the default browser switch has to correct itself from that result alone.
Every dialog with a card now resolves a config, so the fallback no longer has to advance past any of them.
LukasPaczos
force-pushed
the
refactor/lpaczos/config-driven-linear-onboarding-dialogs/quick-setup-dock-widget
branch
from
August 5, 2026 15:36
0fbbd40 to
b2208b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1217183142109150?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/481882893211075/task/1216854264994244
API Proposals URL(s) (if applicable):
Description
Step 3 of the tech design: ports the remaining screens to the config-driven onboarding renderer. This PR covers below binders:
Steps to test this PR
base flow
skip flow
Note
Medium Risk
User-facing onboarding changes that drive default browser, widgets, and omnibar/search preferences, with substantial new interaction logic; coverage is strong in view model and resolver tests.
Overview
Ports add to dock, widget prompt, and quick setup into the config-driven onboarding renderer instead of auto-skipping or stubbing those steps.
Add to dock and widget prompt get new
ContentConfigtypes, resolver entries, and binders (dock includes looping tutorial video on aTextureView). Quick setup is a stateful screen: toggles for default browser and widget, rows for address bar position and search/AI options, with state held in the view model and synced from the OS on resume.The view model wires quick-setup interactions to commands (system default-browser prompt vs settings, add-widget prompt vs remove-widget instructions, existing quick-setup bottom sheets) and updates
QuickSetupContentStatebefore side effects so declined dialogs can revert switches withoutStateFlowdeduping blocking the binder. Quick-setup default-browser results update install store state but do not advance the plan or fire the standalone default-browser onboarding pixels.The welcome fragment handles the new commands, a separate activity result for quick-setup default browser, bottom-sheet result listeners, and
syncQuickSetupSwitcheswhen default app settings cannot be opened.Reviewed by Cursor Bugbot for commit b2208b0. Bugbot is set up for automated code reviews on this repo. Configure here.