Pin MMKVCore 2.4.0 to fix iOS memset_s build failure - #13
Merged
Conversation
MMKVCore 2.4.1 fails to compile (memset_s). Pinning only MMKVAppExtension still resolves MMKVCore 2.4.1 because ~> 2.4.0 allows it. Co-authored-by: Dominic Seung <dominic@seung.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
dsnsgithub
marked this pull request as ready for review
August 20, 2026 10:21
The iOS test job failed immediately with permission denied (exit 126) because the script was checked in as 100644. Co-authored-by: Dominic Seung <dominic@seung.dev>
dsnsgithub
added a commit
that referenced
this pull request
Aug 20, 2026
* Revert "remove workflows to fix later" This reverts commit 2598c87. * run build/test workflows always * Revert "run build/test workflows always" This reverts commit a04d704. * ci: retrigger workflows * Pin MMKVCore 2.4.0 to fix iOS memset_s build failure (#13) * pin MMKVCore and MMKVAppExtension to 2.4.0 MMKVCore 2.4.1 fails to compile (memset_s). Pinning only MMKVAppExtension still resolves MMKVCore 2.4.1 because ~> 2.4.0 allows it. Co-authored-by: Dominic Seung <dominic@seung.dev> * make maestro-test.sh executable The iOS test job failed immediately with permission denied (exit 126) because the script was checked in as 100644. Co-authored-by: Dominic Seung <dominic@seung.dev> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> * remove concurrency ---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pin both mmkvcore and mmkvappextension
fixes: Tencent/MMKV#1675