ci: scope SpotBugs to a PR's changed modules (per-module skip)#1400
Draft
joaodinissf wants to merge 3 commits into
Draft
ci: scope SpotBugs to a PR's changed modules (per-module skip)#1400joaodinissf wants to merge 3 commits into
joaodinissf wants to merge 3 commits into
Conversation
Replace the pmd/checkstyle jobs with a parallel shape that gives early,
inline feedback and stops re-running analysis inside the build:
- lint: compile + pmd:pmd + checkstyle:checkstyle (SARIF) + pmd:cpd-check,
-T 2C, --fail-never; gates by counting the merged SARIF (+ cpd.xml grep).
Fails in ~3-5 min on its own check, independent of the build.
- spotbugs: compile + spotbugs:spotbugs (SARIF), -Xmx4g, own parallel lane
(the slow analysis).
- maven-verify: build + tests only; the redundant checkstyle/pmd/spotbugs
goals are dropped (now owned by lint/spotbugs).
- line-endings: unchanged.
All three emit SARIF 2.1.0, merged per tool and uploaded to Code Scanning
(security-events: write) for inline annotations on the PR diff + Security tab.
No custom Python annotator.
Count-gate rather than the *:check goals: the check goals @Execute-fork a
second analysis and cannot emit SARIF, and without the full compile classpath
they false-positive on type-resolving rules. Each report goal runs once
(full-reactor compile -> correct + SARIF) and the gate counts the result.
Rationale + tables in docs/ci-static-analysis-design.md; measurement protocol
in docs/ci-measurement-protocol.md.
CPD gating is wired but inert until dsldevkit#1339 lowers the token threshold.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The lint and spotbugs jobs fall back to a restore-key prefix on a pom.xml change; maven-verify lacked it, so any pom change gave it a hard cache miss and a full ~/.m2 re-download. Add the same restore-keys for parity across all three Maven jobs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
SpotBugs' per-module analysis is the spotbugs job's long pole. A PR only needs its changed modules scanned, so a pre-step injects <spotbugs.skip>true> into every unchanged reactor module's pom — the plugin then skips the goal, and the per-module JVM fork, for them. The full-reactor compile is kept (a changed module keeps its complete aux-classpath); a build/config change falls back to a full scan. pull_request only — master/snapshot run a full scan. -Dspotbugs.onlyAnalyze was the cleaner-looking alternative but screens too late (after the per-module fork), ~17% vs ~88% measured; the script header documents the migration if an upstream SpotBugs early-exit ever lands. - .github/scripts/compute-spotbugs-skip.sh: diff -> changed modules -> inject skip into the unchanged ones (idempotent; build/config change -> full scan). - verify.yml spotbugs job: fetch-depth 0 + a scope step before compile; -Djgit.dirtyWorkingTree=ignore because the scope step dirties poms on purpose and this job releases nothing (releases/maven-verify keep =error); SARIF upload guarded so an empty scan set (no module scanned) doesn't fail the upload. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on #1396 → #1399. Against
masterthe diff includes those commits (they drop out as they merge) — review only the SpotBugs-scoping commit (compute-spotbugs-skip.sh+ the spotbugs-job edits inverify.yml).Problem
SpotBugs is the
spotbugsjob's long pole (per-module bytecode analysis + a JVM fork per module). A PR only needs its changed modules scanned.What this does
A pre-step injects
<spotbugs.skip>true>into every unchanged reactor module's pom, so the plugin skips the goal — and the per-module fork — for them. The full-reactor compile is kept (a changed module keeps its complete aux-classpath).pull_requestonly; master/snapshot run a full scan. A build/config change → full scan (fail-safe)..github/scripts/compute-spotbugs-skip.sh— diff → changed modules → inject skip into the unchanged ones (idempotent; never touchesddk-parent).verify.ymlspotbugs job —fetch-depth: 0+ the scope step;-Djgit.dirtyWorkingTree=ignore(the scope step intentionally dirties poms and this job releases nothing — releases/maven-verifykeep=error); SARIF upload guarded against an empty scan set.Validated
Fork probe: a one-module Java change →
scanning 1 / skipping 62; spotbugs job ~1m45s (vs full ~8m44),BUILD SUCCESS, 0 violations, SARIF uploaded; all other jobs green.Why not
-Dspotbugs.onlyAnalyzeCleaner-looking (one flag) but SpotBugs screens too late (after the per-module fork) — ~17% vs ~88% measured. If an upstream SpotBugs early-exit lands, switch to
onlyAnalyzeand drop this script (noted in the script header).🤖 Generated with Claude Code