fix: always log the null-marker-creator error, not only when debug is enabled#1388
Draft
joaodinissf wants to merge 1 commit into
Draft
fix: always log the null-marker-creator error, not only when debug is enabled#1388joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
… enabled CheckMarkerUpdateJob logged "Could not create markers. The marker creator is null." at ERROR level but only inside `if (LOGGER.isDebugEnabled())`, so in production (debug off) a genuine failure to create markers was silent. Remove the isDebugEnabled guard — isDebugEnabled is for gating expensive debug/trace output, not real errors. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckMarkerUpdateJoblogged "Could not create markers. The marker creator is null." at ERROR level but wrapped inif (LOGGER.isDebugEnabled()), so in production (debug off) a genuine failure to create markers was silently swallowed. Removed theisDebugEnabledguard — that guard is for gating expensive debug/trace output, not real errors.Found by a repo-wide inconsistency sweep.
🤖 Generated with Claude Code