fix: guard pluginXml (not its never-null entries list) in CompareFragment2#1385
Draft
joaodinissf wants to merge 1 commit into
Draft
fix: guard pluginXml (not its never-null entries list) in CompareFragment2#1385joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
…ment2 generate() guarded `if (projectConfig.eclipsePlugin.pluginXml.entries !== null)`, but `entries` is a final, never-null list, so the guard is always true and never protects the null-pluginXml case it intends to — and it NPEs on `.entries` when pluginXml itself is null. Guard the container `pluginXml`, matching the adjacent manifest guard (line 67) and the superclass ResourceFactoryFragment2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompareFragment2.generate()guardedif (projectConfig.eclipsePlugin.pluginXml.entries !== null). ButPluginXmlAccess.entriesisval List … = newArrayList— final and never null — so the guard is always true (never protects the intended null case) and dereferencespluginXml.entriesinside the guard, NPEing whenpluginXmlitself is null.Fixed to guard the container
pluginXml, matching the adjacentmanifest != nullguard (line 67) and the superclassResourceFactoryFragment2(which this class extends).Found by a repo-wide inconsistency sweep.
🤖 Generated with Claude Code