build: enable the Tycho baseline version#1371
Merged
Merged
Conversation
7af36f6 to
5d5f1f7
Compare
af5462f to
b53a9e4
Compare
700a0dd to
f5539c8
Compare
joaodinissf
reviewed
May 29, 2026
| <artifactId>ddk-parent</artifactId> | ||
| <groupId>com.avaloq.tools.ddk</groupId> | ||
| <version>17.3.0-SNAPSHOT</version> | ||
| <version>17.3.1-SNAPSHOT</version> |
Collaborator
There was a problem hiding this comment.
17.3.1 landed on the parent ref here instead of as the module's own <version> (which is missing). Every other module is (parent 18.0.1, own 17.3.1). Since ddk-parent is now 18.0.1-SNAPSHOT, this parent won't resolve — it only escapes CI because workflow isn't in ddk-parent's <modules>. Expected:
<parent>
...
<version>18.0.1-SNAPSHOT</version>
</parent>
<version>17.3.1-SNAPSHOT</version>Verified it's the only such deviation across the diff.
Left by Claude at João's request.
Member
Author
There was a problem hiding this comment.
Good catch. I have however removed the pom.xml instead of adapting it.
joaodinissf
requested changes
May 30, 2026
This commit re-enables the Tycho baseline version check now that the
first v18.0.0 release is published to GitHub Pages, and adjusts the
project's version layout to support that workflow going forward.
In pom.xml, the parent POM coordinate is bumped to 18.0.1-SNAPSHOT so
the build aggregator moves ahead of the published release stream. A new
target.platform.version property is introduced and
target-platform-configuration switches from ${project.version} to
${target.platform.version}. This decouples the target platform from the
bundle versions, so future parent bumps don't force every bundle to be
re-released.
A separate snapshot.repo.url property is added, and the
tycho-p2-plugin baselineRepositories configuration is moved into
<pluginManagement> (matching the lsp4e pattern). The temporary
<baseline.skip>true</baseline.skip> workaround is removed so
compare-version-with-baselines runs on every build.
All child plugin/feature poms are updated to reference the new
parent (18.0.1-SNAPSHOT) and now carry an explicit <version> element so
each bundle keeps its own coordinate independent of the parent. This is
required because Tycho needs the pom version to align with the MANIFEST
Bundle-Version.
Because the PR modifies every bundle's pom.xml, the jgit qualifier picks
up today's commit timestamp, which the re-enabled baseline check
correctly rejects against the already-published 17.3.0.qualifier bundles
("Only qualifier changed… expected bigger x.y.z"). To satisfy semver,
all MANIFEST.MF files, both feature.xml files
(com.avaloq.tools.ddk.feature, com.avaloq.tools.ddk.runtime.feature),
the child pom <version> elements, and category.xml are bumped from
17.3.0 to 17.3.1. ddk-parent, ddk-target, and ddk-repository remain at
18.0.1-SNAPSHOT. Exceptionally the pom.xml of
com.avaloq.tools.ddk.workflow has been removed, as it isn't in
ddk-parent's <modules> and therefore not part of the CI/delivery.
From now on the parent POM coordinate is decoupled from the bundle
stream, the baseline check is active and protects against accidental
re-publishing of released bundles without a version bump, and all
bundles move to 17.3.1 to reflect the content change introduced by
commit.
f5539c8 to
60aafa4
Compare
joaodinissf
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit re-enables the Tycho baseline version check now that the
first v18.0.0 release is published to GitHub Pages, and adjusts the
project's version layout to support that workflow going forward.
In pom.xml, the parent POM coordinate is bumped to 18.0.1-SNAPSHOT so
the build aggregator moves ahead of the published release stream. A new
target.platform.version property is introduced and
target-platform-configuration switches from ${project.version} to
${target.platform.version}. This decouples the target platform from the
bundle versions, so future parent bumps don't force every bundle to be
re-released.
A separate snapshot.repo.url property is added, and the
tycho-p2-plugin baselineRepositories configuration is moved into
(matching the lsp4e pattern). The temporary
<baseline.skip>true</baseline.skip> workaround is removed so
compare-version-with-baselines runs on every build.
All child plugin/feature poms are updated to reference the new
parent (18.0.1-SNAPSHOT) and now carry an explicit element so
each bundle keeps its own coordinate independent of the parent. This is
required because Tycho needs the pom version to align with the MANIFEST
Bundle-Version.
Because the PR modifies every bundle's pom.xml, the jgit qualifier picks
up today's commit timestamp, which the re-enabled baseline check
correctly rejects against the already-published 17.3.0.qualifier bundles
("Only qualifier changed… expected bigger x.y.z"). To satisfy semver,
all MANIFEST.MF files, both feature.xml files
(com.avaloq.tools.ddk.feature, com.avaloq.tools.ddk.runtime.feature),
the child pom elements, and category.xml are bumped from
17.3.0 to 17.3.1. ddk-parent, ddk-target, and ddk-repository remain at
18.0.1-SNAPSHOT. Exceptionally the pom.xml of
com.avaloq.tools.ddk.workflow has been removed, as it isn't in ddk-parent's
and therefore not part of the CI/delivery.
From now on the parent POM coordinate is decoupled from the bundle
stream, the baseline check is active and protects against accidental
re-publishing of released bundles without a version bump, and all
bundles move to 17.3.1 to reflect the content change introduced by commit.