chore: bump the npm-development group with 30 updates [AR-89256] - #709
Open
mmurawski-dn wants to merge 3 commits into
Open
chore: bump the npm-development group with 30 updates [AR-89256]#709mmurawski-dn wants to merge 3 commits into
mmurawski-dn wants to merge 3 commits into
Conversation
✅ Deploy Preview for drivenets-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vpolessky-dn
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #696 (Dependabot cannot be pushed to from a fork).
Takes all 30 bumps from the
npm-developmentgroup, rebased onto currentmain, plus the code adaptations the majors require.Majors, verified against our actual usage
@changesets/readgenerate-dependabot-changeset.tsreadChangesets(identical signature)@changesets/writewriteChangeset(identical signature)@changesets/gitgetChangedPackagesSinceRef({ cwd, ref })changedFilePatternsoptional@changesets/should-skip-packageshouldSkipPackage(pkg, { ignore, allowPrivatePackages })@changesets/typesChangeset{ summary, releases }unchanged@figma/code-connectfigma connect parse/publish --exit-on-unreadable-filescliVersion: 2.0.0Only the two
@typescript-eslint/no-deprecatederrors that failed Lint on #696 required a code change. The old default exports still exist, so nothing was broken at runtime — this is an adaptation, not a fix.Additional finding: duplicate
viterequired a dedupeRebasing onto current
main(which has since merged the storybook and vitest groups) surfaced a failure #696 never saw:Cause: two
viteversions in the tree.@drivenets/vite-plugin-design-systemdeclaresvite: "*"as a peer, which pnpm left resolved at8.1.5because*was still satisfied, while@drivenets/design-systemmoved to8.2.2. Two distinctPlugintypes collide.pnpm dedupe --check— already a CI gate here — flagged it, along with duplicatezod,sassandpostcss. Runningpnpm dedupecollapses the tree to a singlevite@8.2.2andzod@4.6.1, and typecheck goes green.Verification
Run locally against this branch:
lint— green (was the failing check on chore: bump the npm-development group across 1 directory with 30 updates #696)typecheck— green (after dedupe)format:check,lint:versions,lint:spell,lint:unused,lint:build,dedupe --check— all greenbuild— greenfigma:lint— all 90 Code Connect files parse under 2.0test:storybook-docs— 66/66 passgenerate-dependabot-changeset.ts— executed end to end, exits 0, reads and writes changesets correctly through the new named exportstest— 8 failures in 5 browser test files, identical on cleanmain(8 failed / 241 passed on both, with the set drifting between runs). Pre-existing local flake, not a regression from this branch.Note
Require Changesetskipsdependabot[bot]but not this PR, so a changeset is included by hand.@figma/code-connectresolves to2.0.0;2.0.1is out and permitted by the^2.0.0range.