Skip to content

chore: bump the npm-development group with 30 updates [AR-89256] - #709

Open
mmurawski-dn wants to merge 3 commits into
drivenets:mainfrom
mmurawski-dn:drivenets/michal/AR-89256-bump-dev-deps
Open

chore: bump the npm-development group with 30 updates [AR-89256]#709
mmurawski-dn wants to merge 3 commits into
drivenets:mainfrom
mmurawski-dn:drivenets/michal/AR-89256-bump-dev-deps

Conversation

@mmurawski-dn

Copy link
Copy Markdown
Collaborator

Replaces #696 (Dependabot cannot be pushed to from a fork).

Takes all 30 bumps from the npm-development group, rebased onto current main, plus the code adaptations the majors require.

Majors, verified against our actual usage

Package Bump Our usage Action
@changesets/read 0.6 → 1.0 default import in generate-dependabot-changeset.ts switched to named readChangesets (identical signature)
@changesets/write 0.4 → 1.0 default import, same file switched to named writeChangeset (identical signature)
@changesets/git 3 → 4 getChangedPackagesSinceRef({ cwd, ref }) no change needed — signature unchanged, changedFilePatterns optional
@changesets/should-skip-package 0.1 → 1.0 shouldSkipPackage(pkg, { ignore, allowPrivatePackages }) no change needed — already a named import, shape unchanged
@changesets/types 6 → 7 Changeset no change needed — { summary, releases } unchanged
@figma/code-connect 1.4.9 → 2.0.0 figma connect parse/publish --exit-on-unreadable-files no change needed — all flags still supported; all 90 Code Connect files parse, emitting cliVersion: 2.0.0

Only the two @typescript-eslint/no-deprecated errors that failed Lint on #696 required a code change. The old default exports still exist, so nothing was broken at runtime — this is an adaptation, not a fix.

Additional finding: duplicate vite required a dedupe

Rebasing onto current main (which has since merged the storybook and vitest groups) surfaced a failure #696 never saw:

.storybook/main.ts(36,3): error TS2321: Excessive stack depth comparing types 'Plugin<any>' and 'PluginOption'.

Cause: two vite versions in the tree. @drivenets/vite-plugin-design-system declares vite: "*" as a peer, which pnpm left resolved at 8.1.5 because * was still satisfied, while @drivenets/design-system moved to 8.2.2. Two distinct Plugin types collide.

pnpm dedupe --check — already a CI gate here — flagged it, along with duplicate zod, sass and postcss. Running pnpm dedupe collapses the tree to a single vite@8.2.2 and zod@4.6.1, and typecheck goes green.

Verification

Run locally against this branch:

  • lint — green (was the failing check on chore: bump the npm-development group across 1 directory with 30 updates #696)
  • typecheck — green (after dedupe)
  • format:check, lint:versions, lint:spell, lint:unused, lint:build, dedupe --check — all green
  • build — green
  • figma:lint — all 90 Code Connect files parse under 2.0
  • test:storybook-docs — 66/66 pass
  • generate-dependabot-changeset.ts — executed end to end, exits 0, reads and writes changesets correctly through the new named exports
  • test — 8 failures in 5 browser test files, identical on clean main (8 failed / 241 passed on both, with the set drifting between runs). Pre-existing local flake, not a regression from this branch.

Note

Require Changeset skips dependabot[bot] but not this PR, so a changeset is included by hand.

@figma/code-connect resolves to 2.0.0; 2.0.1 is out and permitted by the ^2.0.0 range.

@netlify

netlify Bot commented Sep 11, 2026

Copy link
Copy Markdown

Deploy Preview for drivenets-design-system ready!

Name Link
🔨 Latest commit 5e060b3
🔍 Latest deploy log https://app.netlify.com/projects/drivenets-design-system/deploys/6aa7a98bdbcb3e0008fe248a
😎 Deploy Preview https://deploy-preview-709--drivenets-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants