Add support for S3 Multi-Region Access Point (MRAP) URLs#557
Open
fedemengo wants to merge 6 commits intodrivendataorg:masterfrom
Open
Add support for S3 Multi-Region Access Point (MRAP) URLs#557fedemengo wants to merge 6 commits intodrivendataorg:masterfrom
fedemengo wants to merge 6 commits intodrivendataorg:masterfrom
Conversation
Author
|
the changes were simple enough, @pjbull gentle ping for review |
pjbull
requested changes
Apr 17, 2026
Member
pjbull
left a comment
pjbull
left a comment
There was a problem hiding this comment.
A couple comments.Also is it possible to update the tests to use s3_rig following the pattern of the existing tests rather than using S3Path directly (as in some tests) or using monkeypatch as in the others.
| :type: :class:`str` | ||
| """ | ||
| if match := _MRAP_PATTERN.match(str(self)): | ||
| return match.group("arn") |
Member
There was a problem hiding this comment.
Let's cache this since it shouldn't change.
| if ( | ||
| not (self.root / Key).exists() | ||
| or (self.root / Key).is_dir() | ||
| or Bucket != DEFAULT_S3_BUCKET_NAME |
Member
There was a problem hiding this comment.
IIRC some of the tests use this check in some scenarios. Can we also just add a simple check that it doesn't have '.mrap' here
fedemengo
force-pushed
the
feat/support-s3-mrap
branch
from
3106e54 to
b86732d
Compare
Author
|
I replaced S3Path with rig_ops when tests is not purly path parsing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #556
Changes
cloudpathlib/s3/s3path.py: added _MRAP_PATTERN regex and overridden bucket property on S3Pathtests/mock_clients/mock_s3.py: removed bucket name check from head_object (the mock never routes by bucket, only by key)tests/test_s3_specific.py: added 3 tests covering bucket/key parsing, path manipulation, and end-to-end file operations via themock backend
Note: using MRAP paths requires
botocore[crt]for SigV4a signing:pip install botocore[crt]Contributor checklist:
CONTRIBUTING.mdCloses #issueappears in the PR summary (e.g.,Closes #123).HISTORY.mdwith the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.