chore(repo): replace Cisco skill scanner with NVIDIA SkillSpector#51
Open
GangGreenTemperTatum wants to merge 1 commit into
Open
chore(repo): replace Cisco skill scanner with NVIDIA SkillSpector#51GangGreenTemperTatum wants to merge 1 commit into
GangGreenTemperTatum wants to merge 1 commit into
Conversation
- Swap scripts/security-scan.sh from cisco-ai-skill-scanner to skillspector installed from git+https://github.com/NVIDIA/SkillSpector. - Update .github/workflows/security-scan.yml to run SkillSpector in static mode (--no-llm) and upload SARIF to GitHub Code Scanning. The workflow reports findings but does not block merges while risk thresholds are being tuned for security-focused capabilities. - Rewrite scripts/test_security_scan.sh for SkillSpector output format, SARIF validation, and malicious-vs-clean risk-score assertions. - Rename scan-policy.yaml to scan-policy.yaml.cisco-legacy; SkillSpector does not consume the Cisco policy format. - Update README.md and Justfile references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the Cisco AI skill scanner with NVIDIA SkillSpector for capability security scanning.
What's included
scripts/security-scan.sh— rewritten to useuvx --from git+https://github.com/NVIDIA/SkillSpector skillspectorinstead ofcisco-ai-skill-scanner. Supports--format,--sarif,--json, and--llmflags. Defaults to--no-llmfor deterministic, API-key-free scans..github/workflows/security-scan.yml— updated to install SkillSpector from git, run static analysis (--no-llm), generate SARIF, and upload to GitHub Code Scanning. The scan step usescontinue-on-error: truebecause security-focused capabilities often score high by design.scripts/test_security_scan.sh— rewritten for SkillSpector: verifies install from git, JSON/SARIF output, and that the malicious fixture scores higher than the clean fixture.scan-policy.yaml— renamed toscan-policy.yaml.cisco-legacybecause SkillSpector does not consume the Cisco policy format.README.mdandJustfile— updated references and notes.Key differences from Cisco scanner
cisco-ai-skill-scannergit+https://github.com/NVIDIA/SkillSpector(not on PyPI yet)skill-scanner scan-all <dir>skillspector scan <path>--recursivescan-policy.yaml--use-behavioral--no-llmto disable (default enabled)--fail-on-severity highValidation
bash -n scripts/security-scan.sh scripts/test_security_scan.sh✅./scripts/security-scan.sh ai-red-teamingproduces terminal output and writes SARIF/JSON ✅./scripts/test_security_scan.sh -v→ 16 passed, 0 failed ✅python3 -m pytest capabilities/web-security/tests/ --ignore=capabilities/web-security/tests/test_bbscope.py -q→ 153 passed ✅Notes and open questions
uvcaches builds aggressively, but this is slower than a PyPI install.scan-policy.yamltuning is removed. This means offensive-security capabilities will naturally produce HIGH/CRITICAL scores. The workflow currently reports these without blocking merges.