Fix leaking io coroutines#3109
Merged
Merged
Conversation
Owner
|
thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found one more leak in the transport layer cleanup. Previously, I/O tasks were only being reclaimed when the peer (broker) closed the connection and even then, only as a side effect of the read-error path. When the broker disconnected, the socket became readable, returned an EOF error, and forced the task to abort and exit.
However, on locally-initiated closes (like idle-connection reaping, request timeouts, or rebalances), transport._close() would close the socket and unregister it without ever cancelling the parked I/O waiters. Because there was no incoming I/O event to trigger an error and wake them up, the reader and writer coroutines stayed permanently stranded in
net._pending_tasksin aWAIT_IOstate.