Skip to content

fix(ValidateForm): support formless - #8295

Merged
ArgoZhang merged 2 commits into
mainfrom
dev-dt
Aug 4, 2026
Merged

fix(ValidateForm): support formless#8295
ArgoZhang merged 2 commits into
mainfrom
dev-dt

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Aug 4, 2026

Copy link
Copy Markdown
Member

Link issues

fixes #8294

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Prevent errors when ValidateForm is initialized with an ID that does not exist in the DOM, allowing use in formless contexts.

@bb-auto bb-auto Bot added the bug Something isn't working label Aug 4, 2026
@bb-auto bb-auto Bot added this to the v10.9.0 milestone Aug 4, 2026
@sourcery-ai

sourcery-ai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Guard ValidateForm initialization to safely handle cases where the target element does not exist, preventing errors when used without an associated form element ("formless" support).

File-Level Changes

Change Details Files
Make ValidateForm initialization resilient when the target element is missing, only binding events when a valid element is found and dissubmit is enabled.
  • Wrap element lookup and setup logic in a null-check to skip initialization when document.getElementById returns null.
  • Retain existing data storage via Data.set and event binding via bind(el) but execute them only when the element exists.
  • Preserve the dissubmit attribute check and conditional binding logic under the new guard.
src/BootstrapBlazor/Components/ValidateForm/ValidateForm.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#8294 Prevent runtime errors in ValidateForm when used in formless mode (no associated DOM element), ensuring it safely handles the absence of the target element.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang
ArgoZhang merged commit c80e003 into main Aug 4, 2026
5 checks passed

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider returning early when el is not found (e.g., if (!el) return;) to reduce nesting and keep the init function flatter and easier to read.
  • If init failing to find an element indicates a misconfiguration, you may want to add a debug log or comment to make this silent failure more discoverable during development.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider returning early when `el` is not found (e.g., `if (!el) return;`) to reduce nesting and keep the `init` function flatter and easier to read.
- If `init` failing to find an element indicates a misconfiguration, you may want to add a debug log or comment to make this silent failure more discoverable during development.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang
ArgoZhang deleted the dev-dt branch August 4, 2026 09:52
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8939349) to head (80b8922).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8295   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          769       769           
  Lines        34478     34478           
=========================================
  Hits         34478     34478           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(ValidateForm): Formless 模式下报错

1 participant