Skip to content

fix(Table): make Rows of TableColumn work on compact mode#8107

Merged
ArgoZhang merged 3 commits into
mainfrom
fix-table
Jun 11, 2026
Merged

fix(Table): make Rows of TableColumn work on compact mode#8107
ArgoZhang merged 3 commits into
mainfrom
fix-table

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Jun 11, 2026

Copy link
Copy Markdown
Member

Link issues

fixes #8106

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Prevent compact table mode from incorrectly applying single-line height to form controls that specify a rows attribute.

Copilot AI review requested due to automatic review settings June 11, 2026 02:43
@bb-auto bb-auto Bot added the bug Something isn't working label Jun 11, 2026
@bb-auto bb-auto Bot added this to the v10.7.0 milestone Jun 11, 2026
@sourcery-ai

sourcery-ai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts compact table cell styling so that only single-line form controls get a forced compact height, allowing multi-row controls (like textareas) to render correctly in table compact mode.

File-Level Changes

Change Details Files
Restrict compact-mode height override to non-multiline form controls inside in-cell table editing.
  • Add :not([rows]) filter to the .table-sm .table-cell.is-incell .form-control selector
  • Preserve the existing compact height calculation for affected controls
src/BootstrapBlazor/Components/Table/Table.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#8106 Ensure that the Rows setting of TableColumn (i.e., multiline form controls with a rows attribute) works correctly when the table is in compact mode (table-sm).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes compact (.table-sm) in-cell editing styling so that form controls with a rows attribute (typically <textarea rows="..."> generated from TableColumn.Rows) are no longer forced into a single-line height, restoring expected multi-line behavior. It also bumps the package version to the next beta.

Changes:

  • Update compact table CSS to avoid applying fixed height to .form-control elements that specify rows.
  • Bump BootstrapBlazor package version from 10.7.2-beta01 to 10.7.2-beta02.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/BootstrapBlazor/Components/Table/Table.razor.scss Excludes [rows] controls from compact-mode fixed height so multi-line textareas can size correctly.
src/BootstrapBlazor/BootstrapBlazor.csproj Increments library version to 10.7.2-beta02.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (78fe4d2) to head (20e1a3d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8107   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          766       766           
  Lines        34204     34204           
  Branches      4696      4696           
=========================================
  Hits         34204     34204           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@ArgoZhang ArgoZhang disabled auto-merge June 11, 2026 02:53
@ArgoZhang ArgoZhang merged commit bb912ea into main Jun 11, 2026
7 checks passed
@ArgoZhang ArgoZhang deleted the fix-table branch June 11, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Table): make Rows of TableColumn work on compact mode

2 participants