Conversation
Expose the Roslyn LSP project loading option through VS Code configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5615e2cd-8b86-40a5-808b-47f8fa893b35
Verify the Roslyn option name maps to the contributed VS Code setting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5615e2cd-8b86-40a5-808b-47f8fa893b35
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Two moderate review issues remain unresolved.
Review tier: Lite
Findings: None
What changed in this PR
Adds the VS Code configuration counterpart for Roslyn on-demand project loading.
Changes:
- Declares
dotnet.projects.loadOnDemandas a boolean enabled by default. - Adds its English configuration description.
| File | Summary | Review |
|---|---|---|
package.nls.json |
Adds the setting description. | Moderate: add the key to every locale file. (1 vote) |
package.json |
Declares the new configuration setting. | Moderate: add coverage to configurationMiddleware.test.ts. (1 vote) |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "configuration.dotnet.server.environmentVariables": "Custom environment variables to pass to the language server process. Specify as key-value pairs, for example: { \"DOTNET_GCName\": \"libclrgc.dylib\" }. (Requires extension restart)", | ||
| "configuration.dotnet.enableXamlTools": "Enables XAML tools when using C# Dev Kit. (Requires extension restart)", | ||
| "configuration.dotnet.projects.enableAutomaticRestore": "Enables automatic NuGet restore if the extension detects assets are missing.", | ||
| "configuration.dotnet.projects.loadOnDemand": "Loads projects when a language feature first requests a file they contain instead of loading every project at startup.", |
Member
There was a problem hiding this comment.
Suggested change
| "configuration.dotnet.projects.loadOnDemand": "Loads projects when a language feature first requests a file they contain instead of loading every project at startup.", | |
| "configuration.dotnet.projects.loadOnDemand": "Discovers and loads projects when you open C# files", |
"when a language feature first requests a file" was a bit pithy.
jasonmalinowski
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the VS Code configuration counterpart for Roslyn on-demand project loading.
The Roslyn language server requests this setting as
projects.dotnet_load_on_demand; the configuration middleware maps it todotnet.projects.loadOnDemand.Counterpart to dotnet/roslyn#85234.