Update roslyn to 5.11.0-1.26379.2

[JoeRobich]

View Complete Diff of Changes

• Escape token text in VB grammar generator (PR: #84659)
• Fix three defects in the VB grammar generator (PR: #84661)
• Unsafe evolution: ensure diagnostics are picked up by IDE (PR: #84603)
• Fix daemon relay exit classification (PR: #84666)
• Restore EA project references in LanguageServer.csproj (PR: #84663)
• Ensure we don't log errors when we are cancelling loading (PR: #84622)
• Report LSP daemon lifecycle telemetry (PR: #84652)
• Unions: cache TryGetValue methods on NamedTypeSymbol representing a union type (PR: #84645)
• Update version to 18.11, set insertions to draft (PR: #84649)
• Trim lsp dispatch allocations (PR: #84651)
• Reduce LSP request handling allocations (PR: #84623)
• Preserve line breaks after collapsed Razor blocks (PR: #84630)
• Honour C# new line settings in Razor auto insert (PR: #84632)
• Provide access to SymbolKey for TestDiscovery (PR: #84643)
• Add plan-first working loop to Copilot instructions (PR: #84532)
• Unions: cache some calculated results on NamedTypeSymbol representing a union type (PR: #84589)
• Fix IL3000: guard Assembly.Location access behind RuntimeFeature.IsDynamicCodeSupported (PR: #84599)
• Fix typo in OverloadResolution.PairedExtensionOperatorSignatureComparer.Equals (PR: #84639)
• Fix duplicate SyntaxNodeActions for union declarations and its members (PR: #84604)

[Copilot]

Pull request overview

Bumps the Roslyn component version used by the VS Code C# extension to 5.11.0-1.26379.2, and records the update (with notable upstream items) in the extension changelog.

Changes:

• Update the default Roslyn version from 5.10.0-1.26376.1 to 5.11.0-1.26379.2.
• Add a new CHANGELOG.md entry under 2.147.x describing the Roslyn update and highlighting included upstream fixes/optimizations.

Show a summary per file

File	Description
package.json	Updates the extension’s default Roslyn version to 5.11.0-1.26379.2.
CHANGELOG.md	Adds a 2.147.x changelog entry documenting the Roslyn version bump and key upstream PRs.

Copilot's findings

• Files reviewed: 2/2 changed files
• Comments generated: 0

[Copilot]

Copilot's findings

• Files reviewed: 2/2 changed files
• Comments generated: 0 new

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (2)

test/vscodeLauncher.ts:24

• This function receives an env object but checks process.env.CODE_VERSION instead, which makes it harder for callers to override the VS Code version via the provided env. Using env.CODE_VERSION also keeps the log message consistent (and fixes the typo in "overriden").

    if (process.env.CODE_VERSION) {
        console.log(`VSCode version overriden to ${process.env.CODE_VERSION}.`);
        vscodeVersion = process.env.CODE_VERSION;
    }

test/vscodeLauncher.ts:20

• The comment says the VS Code version is pinned due to macOS test issues, but the current default pins all platforms to 1.130. If the intent is only to work around macOS legs, keep other platforms on 'insiders' (or whatever default you want) to preserve broader coverage.

    // Normally we test against 'insiders' but have pinned to a previous release due to
    // issues in the MacOS test legs.
    let vscodeVersion = '1.130';

• Files reviewed: 3/3 changed files
• Comments generated: 0 new

[peterwald]

I believe the fix for this is to upgrade @vscode/test-electron to 3.1.0. We ran into this in vs-green as well.

[JoeRobich]

Will give that a shot. Thanks!

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (1)

package.json:146

• This PR is titled/described as a Roslyn update, but it also bumps @vscode/test-electron to a new major version (and in the lockfile this brings a higher minimum Node engine). Please either split this dependency upgrade into a separate PR or update the PR description to explicitly call out why this is needed as part of the Roslyn update, since it can affect how contributors run/diagnose tests locally.

    "@vscode/test-electron": "^3.1.0",

• Files reviewed: 2/3 changed files
• Comments generated: 0 new

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (1)

CHANGELOG.md:14

• This PR also updates the bundled Source Test Discovery version (defaults.testDiscovery), but the changelog entry for 2.147.x only mentions the Roslyn bump. Please add a changelog bullet for the test discovery update so the release notes reflect all component-version changes.

  * Honour C# new line settings in Razor auto insert (PR: [#84632](https://github.com/dotnet/roslyn/pull/84632))
* Update Roslyn to 5.10.0-1.26376.1 (PR: [#9584](https://github.com/dotnet/vscode-csharp/pull/9584))

• Files reviewed: 2/3 changed files
• Comments generated: 0 new