Disable newly added tests on interpreter#131250
Conversation
They timeout
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli |
|
@eiriktsarpalis @krwq I'm wondering if these tests would better be suited as a microbenchmark in |
There was a problem hiding this comment.
Pull request overview
Adjusts System.Private.Xml performance-oriented attribute-duplicate-check tests to be skipped when running under the CoreCLR interpreter, avoiding interpreter-run timeouts while keeping coverage for normal JIT runs.
Changes:
- Converted the affected
[Fact]tests to[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotCoreClrInterpreter))]. - Applied the same condition to the Release-only (
#if !DEBUG) variant of the test.
Agreed. |
Some of the tests timeout when running under coreclr interpreter, which is much slower than jit.
Tests added in #130968