[release/8.0-staging] Skip empty iOS NativeAOT Helix submission#131209
Open
davidnguyen-tech wants to merge 1 commit into
Open
[release/8.0-staging] Skip empty iOS NativeAOT Helix submission#131209davidnguyen-tech wants to merge 1 commit into
davidnguyen-tech wants to merge 1 commit into
Conversation
The servicing branch no longer has enabled iOS NativeAOT device tests, so preserve build coverage while skipping the empty Helix submission. Keep tvOS behavior unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 332b1207-8473-4b2b-8864-30da72ee4f6b
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Member
Author
|
/azp run runtime-extra-platforms Note This command was posted by GitHub Copilot at the user's request. |
|
No pipelines are associated with this pull request. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the .NET 8 staging Azure Pipelines definitions to skip the libraries “Send to Helix” step for the iOS NativeAOT device leg when it would be empty (due to the device test projects being marked IgnoreForCI), while preserving the iOS NativeAOT build coverage and the tvOS Helix submission.
Changes:
- Update the libraries Helix submission condition in
runtime.ymlto excludeosGroup == ioswhile keeping the existing change-detection gating. - Add an explicit
osGroup != ioscondition to the iOS-like extra-platforms libraries Helix submission. - Add inline comments documenting that the iOS exclusion must be removed if iOS NativeAOT device tests are re-enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/runtime.yml | Wrap the existing libraries Helix submission condition with ne(osGroup, 'ios') so tvOS still submits but iOS doesn’t. |
| eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml | Add condition: ne(variables['osGroup'], 'ios') to skip iOS libraries Helix submission in the iOS-like extra-platforms pipeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
davidnguyen-tech
marked this pull request as ready for review
July 22, 2026 15:45
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Send to Helixstep for the .NET 8 iOS NativeAOT device leg.Context
PR #130473 marked the only two test projects selected by this leg as
IgnoreForCI:iOS.Device.Aot.TestiOS.Device.ExportManagedSymbols.TestThe leg therefore creates no test payload directory. The .NET 8 Helix preparation target then calls
Directory.GetDirectorieson that missing directory and fails with MSB4184 before reaching Helix.Adding only an
Exists(...)guard would change the failure toNo helix work items, because there isstill nothing to submit. This change instead keeps the useful iOS NativeAOT build coverage while
skipping only its now-empty Helix submission. tvOS continues to build and submit its enabled test.
Addresses #130860.
Validation
No helix work itemsfailure.change-detection conditions are preserved.
Note
This pull request description was generated with GitHub Copilot.