Skip to content

Route code-review skill to vectorization skill on SIMD diffs#131151

Merged
tannergooding merged 2 commits into
dotnet:mainfrom
tannergooding:tannergooding-review-asn1-vectorization
Jul 21, 2026
Merged

Route code-review skill to vectorization skill on SIMD diffs#131151
tannergooding merged 2 commits into
dotnet:mainfrom
tannergooding:tannergooding-review-asn1-vectorization

Conversation

@tannergooding

Copy link
Copy Markdown
Member

Adds a content-based trigger so the code-review skill applies the vectorization skill whenever a diff uses SIMD types, regardless of which folder the change lives in.

Previously the skill routed to area specialists only by path glob (.github/instructions/*) or by an existing agent under .github/agents/. vectorization has neither a path-scoped instruction file nor an agent, and SIMD code appears in arbitrary library files, so once a review was underway the vectorization checklist was never re-surfaced -- even though .github/copilot-instructions.md already calls for it. That file isn''t re-consulted mid-skill.

This adds the trigger in two places in .github/skills/code-review/SKILL.md:

  • Step 2 (area discovery): note that some specialists are content-triggered, calling out Vector128/Vector256/Vector512, Vector<T>, and System.Runtime.Intrinsics.*.
  • The area-loading list: a "Content matches (not path-based)" bullet routing the same triggers to the vectorization skill.

Note

This PR description was drafted by GitHub Copilot.

The code-review skill only surfaced area specialists by path glob or by an
existing agent, so content-triggered skills like vectorization were never
re-applied mid-review. Add a content-based trigger (Vector128/256/512,
Vector<T>, System.Runtime.Intrinsics.*) in Step 2 and the area-loading list.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 21, 2026 14:14
@github-actions github-actions Bot added the area-skills Agent Skills label Jul 21, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
15 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the code-review skill playbook to route SIMD-related diffs to the vectorization skill based on diff content (SIMD type usage) rather than file path, so reviewers consistently apply the SIMD/vectorization checklist across the repo.

Changes:

  • Adds a Step 2 note that some specialist skills (notably vectorization) are triggered by diff content.
  • Adds a “Content matches (not path-based)” rule in the instruction-file loading list to apply vectorization when SIMD types are present.
Show a summary per file
File Description
.github/skills/code-review/SKILL.md Documents content-based routing to the vectorization skill when SIMD APIs are used in a diff.

Copilot's findings

Comments suppressed due to low confidence (1)

.github/skills/code-review/SKILL.md:196

  • This content-based SIMD trigger also omits Vector64/Vector64<T>, so Vector64-only diffs won’t match unless they also mention System.Runtime.Intrinsics.* explicitly (many files use a using and refer to Vector64<T> unqualified).
- **Content matches (not path-based):** if the diff uses `Vector128`/`Vector256`/`Vector512`, `Vector<T>`, or `System.Runtime.Intrinsics.*` anywhere, apply the `vectorization` skill in addition to the above. SIMD code appears in arbitrary library files, so this trigger is keyed on content, not folder.
  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread .github/skills/code-review/SKILL.md
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 21, 2026 14:30
@tannergooding
tannergooding enabled auto-merge (squash) July 21, 2026 14:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

Comments suppressed due to low confidence (1)

.github/skills/code-review/SKILL.md:196

  • The SIMD content-trigger list is inconsistent between the new Step 2 bullet (includes Vector64) and the later "Content matches" bullet (does not). This can lead to missing the intended trigger depending on which section a reader follows; align the token list in both places (either include Vector64 here too, or remove it from Step 2).
- **Content matches (not path-based):** if the diff uses `Vector128`/`Vector256`/`Vector512`, `Vector<T>`, or `System.Runtime.Intrinsics.*` anywhere, apply the `vectorization` skill in addition to the above. SIMD code appears in arbitrary library files, so this trigger is keyed on content, not folder.
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new

@tannergooding
tannergooding merged commit c8eff66 into dotnet:main Jul 21, 2026
23 checks passed
@tannergooding
tannergooding deleted the tannergooding-review-asn1-vectorization branch July 21, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-skills Agent Skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants