Route code-review skill to vectorization skill on SIMD diffs#131151
Merged
tannergooding merged 2 commits intoJul 21, 2026
Merged
Conversation
The code-review skill only surfaced area specialists by path glob or by an existing agent, so content-triggered skills like vectorization were never re-applied mid-review. Add a content-based trigger (Vector128/256/512, Vector<T>, System.Runtime.Intrinsics.*) in Step 2 and the area-loading list. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 15 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the code-review skill playbook to route SIMD-related diffs to the vectorization skill based on diff content (SIMD type usage) rather than file path, so reviewers consistently apply the SIMD/vectorization checklist across the repo.
Changes:
- Adds a Step 2 note that some specialist skills (notably
vectorization) are triggered by diff content. - Adds a “Content matches (not path-based)” rule in the instruction-file loading list to apply
vectorizationwhen SIMD types are present.
Show a summary per file
| File | Description |
|---|---|
.github/skills/code-review/SKILL.md |
Documents content-based routing to the vectorization skill when SIMD APIs are used in a diff. |
Copilot's findings
Comments suppressed due to low confidence (1)
.github/skills/code-review/SKILL.md:196
- This content-based SIMD trigger also omits
Vector64/Vector64<T>, so Vector64-only diffs won’t match unless they also mentionSystem.Runtime.Intrinsics.*explicitly (many files use ausingand refer toVector64<T>unqualified).
- **Content matches (not path-based):** if the diff uses `Vector128`/`Vector256`/`Vector512`, `Vector<T>`, or `System.Runtime.Intrinsics.*` anywhere, apply the `vectorization` skill in addition to the above. SIMD code appears in arbitrary library files, so this trigger is keyed on content, not folder.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot's findings
Comments suppressed due to low confidence (1)
.github/skills/code-review/SKILL.md:196
- The SIMD content-trigger list is inconsistent between the new Step 2 bullet (includes
Vector64) and the later "Content matches" bullet (does not). This can lead to missing the intended trigger depending on which section a reader follows; align the token list in both places (either includeVector64here too, or remove it from Step 2).
- **Content matches (not path-based):** if the diff uses `Vector128`/`Vector256`/`Vector512`, `Vector<T>`, or `System.Runtime.Intrinsics.*` anywhere, apply the `vectorization` skill in addition to the above. SIMD code appears in arbitrary library files, so this trigger is keyed on content, not folder.
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
vcsjones
approved these changes
Jul 21, 2026
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a content-based trigger so the
code-reviewskill applies thevectorizationskill whenever a diff uses SIMD types, regardless of which folder the change lives in.Previously the skill routed to area specialists only by path glob (
.github/instructions/*) or by an existing agent under.github/agents/.vectorizationhas neither a path-scoped instruction file nor an agent, and SIMD code appears in arbitrary library files, so once a review was underway the vectorization checklist was never re-surfaced -- even though.github/copilot-instructions.mdalready calls for it. That file isn''t re-consulted mid-skill.This adds the trigger in two places in
.github/skills/code-review/SKILL.md:Vector128/Vector256/Vector512,Vector<T>, andSystem.Runtime.Intrinsics.*.vectorizationskill.Note
This PR description was drafted by GitHub Copilot.