Avoid array allocations when evaluating connections for eviction#131142
Merged
Conversation
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
ManickaP
approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to reduce allocations in SocketsHttpHandler connection eviction evaluation by avoiding List<T>.ToArray() when iterating available HTTP/2 and HTTP/3 connections in HttpConnectionPool.
Changes:
- Replace array snapshots (
ToArray()) withCollectionsMarshal.AsSpan()for available HTTP/2 connections. - Do the same for available HTTP/3 connections when HTTP/3 is enabled.
- Add
System.Runtime.InteropServicesforCollectionsMarshal.
MihaZupan
enabled auto-merge (squash)
July 21, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small perf improvement follow-up to #130476 (didn't want to re-run CI there)