Disable new test on clr interpreter#131139
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/area-system-diagnostics |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts System.Diagnostics.StackTrace async stack trace tests to avoid a failing scenario on the CoreCLR interpreter by isolating the problematic case into its own test and marking it with an interpreter-only skip.
Changes:
- Removes
ThrowsSoonValueTaskSourcefrom the shared async test data set used by the existing theory. - Adds a dedicated
[ConditionalFact]forThrowsSoonValueTaskSource, skipped on CoreCLR interpreter via[ActiveIssue].
Member
Author
|
@tommcdon Could you validate whether it is safe to bring back reporting for offsets without an empty stack, or whether we should do something else here, to model jit behavior. |
lewing
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test added in #130777.
For code like the one below, where the
GetResultof the value task source throws, the correct stacktrace should point to the await as the source of the throw. However, on interpreter, it is pointing to the new instruction.The cause of this seems to be that we only report IL->native offsets for locations where the IL stack is empty, therefore we don't have a location at the await. This seems to be easily fixable via BrzVlad@460eae9. The problem with the fix is that it is a partial revert of #127469 so it has a good chance to lead to regressions on other diagnostic tests.