Skip to content

checking android cpu info files#131129

Closed
eduardo-vp wants to merge 2 commits into
dotnet:mainfrom
eduardo-vp:android-core
Closed

checking android cpu info files#131129
eduardo-vp wants to merge 2 commits into
dotnet:mainfrom
eduardo-vp:android-core

Conversation

@eduardo-vp

Copy link
Copy Markdown
Member

No description provided.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@eduardo-vp

Copy link
Copy Markdown
Member Author

/azp run runtime-androidemulator, runtime-android

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This change adds runtime diagnostics to the NativeAOT Exceptions smoke test (CPU count, server GC state, Android detection, and /sys/devices/system/cpu/* contents). It also introduces an Android-specific early exit in Main, which changes the test’s behavior and expected exit code semantics.

Changes:

  • Print Environment.ProcessorCount, GCSettings.IsServerGC, and OperatingSystem.IsAndroid().
  • Attempt to read and print /sys/devices/system/cpu/{possible,present,online,offline} (with error handling).
  • Return 42 immediately on Android.

Comment thread src/tests/nativeaot/SmokeTests/Exceptions/Exceptions.cs
Copilot AI review requested due to automatic review settings July 21, 2026 02:41
@eduardo-vp

Copy link
Copy Markdown
Member Author

/azp run runtime-androidemulator, runtime-android

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@eduardo-vp eduardo-vp changed the title checking android cpu files checking android cpu info files Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/tests/nativeaot/SmokeTests/Exceptions/Exceptions.cs:54

  • This early return makes the test exit with code 42 on Android before executing the rest of the exception coverage, which contradicts the later Android-specific behavior in this test (it currently returns Pass on Android at the end). If the goal is just to print diagnostics, avoid changing the test outcome.
        if (OperatingSystem.IsAndroid())
        {
            return 42;
        }

Comment thread src/tests/nativeaot/SmokeTests/Exceptions/Exceptions.cs
Comment thread src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Comment thread src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @VSadov
See info in area-owners.md if you want to be subscribed.

@eduardo-vp

Copy link
Copy Markdown
Member Author

/azp run runtime-androidemulator, runtime-android

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@eduardo-vp

Copy link
Copy Markdown
Member Author

/azp run runtime-androidemulator, runtime-android

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@eduardo-vp eduardo-vp closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants